refactor(cram): track locations inside cram lexer #12335
+379
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alizter
force-pushed
the
cram-lex-loc
branch
3 times, most recently
from
d77a6c4 to
c2b1fe0
Compare
Alizter
force-pushed
the
cram-lex-loc
branch
from
c2b1fe0 to
05b4e53
Compare
Alizter
force-pushed
the
cram-lex-loc
branch
2 times, most recently
from
1b4f765 to
96bb60f
Compare
Alizter
force-pushed
the
cram-lex-loc
branch
5 times, most recently
from
611a0a5 to
84c47ad
Compare
We add support for lexing locations in cram tests. Signed-off-by: Ali Caglayan <[email protected]>
|
Have you tried using these locations to improve any error messages yet? I'd like to see some work in that direction as this PR doesn't have any benefits on its own. |
|
@rgrinberg Yes, I've added locations to both the timeout and conflict error messages here: #12657 Once this is merged I will PR those changes separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we enrich the cram test lexer with location information. In order to do this, we need to modify how lines are being lexed so that we can increment the line count correctly.
The tests introduced in #12334 give us some guarantees that we are preserving behaviour.
The motivation for this change is to allow for better error messages related to cram tests. For example, in a future PR we may enrich the timeout error with the exact location of the timed out command.